[SYCL][NFC] More sub_group_mask.hpp cleanup
#18975
Merged
+14
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexeySachkov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
…lify-sub-group-mask-header
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/llvm-gatekeepers please consider merging |
maarquitos14
approved these changes
Sep 12, 2025
| @@ -378,19 +378,11 @@ group_ballot([[maybe_unused]] Group g, [[maybe_unused]] bool predicate) { | |||
| #ifdef __SYCL_DEVICE_ONLY__ | |||
| return sycl::detail::commonGroupBallotImpl(g, predicate); | |||
| #else | |||
| throw exception{errc::feature_not_supported, | |||
| "Sub-group mask is not supported on host device"}; | |||
| // Groups are not user-constructible, this call should not be reachable from | |||
There was a problem hiding this comment.
Would it be worth adding llvm_unreachable here?
There was a problem hiding this comment.
Two concerns here:
llvm_unreachablecomes from LLVM headers that we don't ship (and probably don't want to)- Any "early exits" in form of exception/unreachable may affect host compilation - I'm afraid of unintended side effects like we saw in [SYCL] Fix SYCL_EXTERNAL device code when linking with a static lib #14256
AlexeySachkov
deleted the
private/asachkov/simplify-sub-group-mask-header
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.